Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of Redis flushdb operation #277

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

EmilianoSanchez
Copy link
Contributor

Javascript commons library

What did you accomplish?

  • Removed the usage of the Redis flushdb operation in storage clear methods, because it clears all the data in the Redis database, not just the data related to the SDK instance. However, as the clear methods are not yet in use, this change does not affect the SDK's functionality.

How do we test the changes introduced in this PR?

  • NA

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 30, 2023 16:00
@EmilianoSanchez EmilianoSanchez merged commit cc0faea into redis_storage_improvements Nov 30, 2023
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the redis_clear_methods branch November 30, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants